fix: smaller cohort resource usage for replay filters #25699
+428
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Oct 19, 2024
|
|
||
| remaining_properties = self._strip_person_and_event_and_cohort_properties(self._filter.property_groups) | ||
| if remaining_properties: | ||
| posthoganalytics.capture_exception(UnexpectedQueryProperties(remaining_properties)) |
There was a problem hiding this comment.
i think anything in here is likely going to cause a join and impact performance, lets use exception capture to see when that happens
pauldambra
commented
Oct 19, 2024
posthog/session_recordings/queries/session_recording_list_from_filters.py
Outdated
Show resolved
Hide resolved
pauldambra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see (private) https://posthoghelp.zendesk.com/agent/tickets/19533 and (private) https://posthog.slack.com/archives/C03PB072FMJ/p1729252876401629
when filtering replays by cohort we were joining replay events on person_distinct_id only so we could check if a given person id is in a cohort, and the query would sometimes OOM, but certainly would be slower than necessary
we definitely don't want a join here